Conversation
Codecov Report
@@ Coverage Diff @@
## develop #307 +/- ##
===========================================
+ Coverage 94.39% 94.65% +0.25%
===========================================
Files 89 87 -2
Lines 4156 4038 -118
===========================================
- Hits 3923 3822 -101
+ Misses 233 216 -17
Continue to review full report at Codecov.
|
| router = APIRouter( | ||
| prefix="/cursor", | ||
| tags=["cursor"], |
There was a problem hiding this comment.
I'm not sure we need a route for every setting option. This should probably be routers.setting.py and the calls should be:
- @router.get("/settings/cursor")
- @router.post("/settings/cursor")
- @router.get("/{user_id}/cursor")
There was a problem hiding this comment.
Did you mean that there shouldn't be a [setting_type].py file for each setting type?
So if I have Audio Settings and Cursor Settings, both of them should be in routers.setting.py, but the @router functions should stay the same, only in this new file instead of the old one?
Thanks for your feedback!
…his ticket as well :)
…into feature/cursor
6 participants
No description provided.